Skip to content

External transfer request body parameter names fix #3210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taskain7 wants to merge 3 commits into from
Closed

External transfer request body parameter names fix #3210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17fd3bf
[FINERACT-1724] Fix disabled integration tests
taskain7 May 30, 2023
a1988da
Merge branch 'apache:develop' into develop
taskain7 May 31, 2023
4368140
[FINERACT-1926] Fix request body parameter names
taskain7 May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...or/src/main/java/org/apache/fineract/investor/data/ExternalTransferRequestParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ public final class ExternalTransferRequestParameters {

private ExternalTransferRequestParameters() {}

public static final String SETTLEMENT_DATE = "settlement_date";
public static final String OWNER_EXTERNAL_ID = "owner_external_id";
public static final String TRANSFER_EXTERNAL_ID = "transfer_external_id";
public static final String PURCHASE_PRICE_RATIO = "purchase_price_ratio";
public static final String SETTLEMENT_DATE = "settlementDate";
public static final String OWNER_EXTERNAL_ID = "ownerExternalId";
public static final String TRANSFER_EXTERNAL_ID = "transferExternalId";
public static final String PURCHASE_PRICE_RATIO = "purchasePriceRatio";
public static final String DATEFORMAT = "dateFormat";
public static final String LOCALE = "locale";
}
8 changes: 4 additions & 4 deletions .../integrationtests/investor/externalassetowner/InitiateExternalAssetOwnerTransferTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,10 +346,10 @@ private HashMap<String, String> collaterals(Integer collateralId, BigDecimal qua

private String getSaleRequestJson(String date, String transferExternalId) {
final HashMap<String, String> map = new HashMap<>();
map.put("settlement_date", date);
map.put("owner_external_id", "1234567890987654321");
map.put("transfer_external_id", transferExternalId);
map.put("purchase_price_ratio", "1.234");
map.put("settlementDate", date);
map.put("ownerExternalId", "1234567890987654321");
map.put("transferExternalId", transferExternalId);
map.put("purchasePriceRatio", "1.234");
map.put("dateFormat", "dd MMMM yyyy");
map.put("locale", "en");
return new Gson().toJson(map);
Expand Down