Skip to content

FINERACT-1724: OpenAPI generator SnakeYaml dependency conflict fix#3234

Merged
taskain7 merged 1 commit intoapache:developfrom
galovics:FINERACT-1724-76
Jun 7, 2023
Merged

FINERACT-1724: OpenAPI generator SnakeYaml dependency conflict fix#3234
taskain7 merged 1 commit intoapache:developfrom
galovics:FINERACT-1724-76

Conversation

@galovics
Copy link
Contributor

@galovics galovics commented Jun 7, 2023

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@galovics galovics force-pushed the FINERACT-1724-76 branch 4 times, most recently from 8c7ac44 to 0e566c6 Compare June 7, 2023 11:33
@galovics galovics force-pushed the FINERACT-1724-76 branch from 0e566c6 to bd6e45b Compare June 7, 2023 12:32
@galovics galovics changed the title FINERACT-1724: OpenAPI generator SnakeYaml upgrade to 2.0 from 1.33 FINERACT-1724: OpenAPI generator SnakeYaml dependency conflict fix Jun 7, 2023
Copy link
Contributor

@taskain7 taskain7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taskain7 taskain7 merged commit 20c9c68 into apache:develop Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants