FINERACT-1724-COB-hardlocked-loans-and-inline-cob-issue#3255
Conversation
There was a problem hiding this comment.
Should be rethrown the error here...and logging an error should be used the ERROR level, but at least the WARNING (but usually rather ERROR level)
There was a problem hiding this comment.
This can be removed. Every entry in the accountLocks means its locked and we dont need any filtering...
There was a problem hiding this comment.
I was wondering on this and i think we can try the following:
- start a new transaction for the
loanLockingService.applyLock()method - when there is an error set repeatStatus.CONTINUABLE
- for counter we might wanna use stepExecution commit count (with every run it got increased)
What do you think?
There was a problem hiding this comment.
You might wanna do the filtering at database side
There was a problem hiding this comment.
This does not mean automatically this... i would rather go with a more generic error message...
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please kindly check my comments!
ruchiD
force-pushed
the
FINERACT-1724-COB-hardlocked-loans-and-inline-cob-issue
branch
from
9cb64d9 to
c6f757d
Compare
There was a problem hiding this comment.
I think we dont need this. The commit count got increased with each execution.
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please kindly see my comment!
ruchiD
force-pushed
the
FINERACT-1724-COB-hardlocked-loans-and-inline-cob-issue
branch
from
c6f757d to
e530fd1
Compare
2 participants
Description
Changes to prevent race condition for applying lock and executing cob between regular loan cob and Inline COB.
loan cob retry apply loan lock implementation.
tests.
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.