FINERACT-904 : Post Interest on Account Activation Date for Fixed Dep…#3260
FINERACT-904 : Post Interest on Account Activation Date for Fixed Dep…#3260DheerajKumar19 wants to merge 1 commit intoapache:developfrom
Conversation
…osit and Recurring Deposit Accounts
| } | ||
| periodEndDate = periodEndDate.with(TemporalAdjusters.lastDayOfMonth()); | ||
| break; | ||
| case ACTIVATIONDATE: |
There was a problem hiding this comment.
Can you please explain the math here?
Quote from the story:
Assuming a customer's Fixed Deposit or Recurring Deposit account is activated on Jan 20, we post interest to the customer's account on Feb 20 and on the 20th of every subsequent month until the duration of the account lapses. So for a 6 month Fixed Deposit Account interest would be posted on Feb 20, Mar 20, Apr 20, May 20, June 20 and July 20.
So this is a kind of monthly interest posting...the difference is it is using the activation day + 1 month period, right? I am wondering whether an "ACTIVATION_DATE_MONTHLY" would be better name. Thoughts?
@bharathc27 FYI
There was a problem hiding this comment.
@adamsaghy Yes this is going to increment based on the activation day and increments monthly wrt date. As far as naming convention, please guide me here this is my first time around here at Fineract so please feel free to let me know what other changes I need to be doing here.
There was a problem hiding this comment.
My major concern is the story and the implementation is not matching... Please check the dates in the story and the dates in your test cases.
There was a problem hiding this comment.
@DheerajKumar19 Have you had the chance to check my concern regarding the implementation and the story requirement?
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
2 participants
This PR implements
https://issues.apache.org/jira/browse/FINERACT-904
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.