FINERACT-1724: Loan product creation - duplicate short name fix#3266
Merged
galovics merged 1 commit intoapache:developfrom Jun 27, 2023
Conversation
adamsaghy
reviewed
Jun 21, 2023
Contributor
There was a problem hiding this comment.
We dont need this.
Please check why the LoanProductWritePlatformServiceJpaRepositoryImpl.handleDataIntegrityIssues() method was not handling this properly.
adamsaghy
requested changes
Jun 21, 2023
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please see my comments and please add missing test cases which validates the proper behaviour.
abraham-menyhart
force-pushed
the
FINERACT-1724-loan-product-duplicate-shortname-fix
branch
3 times, most recently
from
208b4be to
c6f6daa
Compare
Contributor
|
@abraham-menyhart Please kindly check the failing integration tests! |
abraham-menyhart
force-pushed
the
FINERACT-1724-loan-product-duplicate-shortname-fix
branch
2 times, most recently
from
0c9b191 to
74ef9c2
Compare
abraham-menyhart
force-pushed
the
FINERACT-1724-loan-product-duplicate-shortname-fix
branch
from
74ef9c2 to
2e41e74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.