Skip to content

FINERACT-1724 overrides default statusListener in integration tests with NopStatusListener#3273

Merged
galovics merged 1 commit intoapache:developfrom
reluxa:FINERACT-1724-no-jansi-error-on-windows-and-intellij-in-integr-tests
Jun 27, 2023
Merged

FINERACT-1724 overrides default statusListener in integration tests with NopStatusListener#3273
galovics merged 1 commit intoapache:developfrom
reluxa:FINERACT-1724-no-jansi-error-on-windows-and-intellij-in-integr-tests

Conversation

@reluxa
Copy link
Copy Markdown
Contributor

@reluxa reluxa commented Jun 26, 2023

Overrides default statusListener with NopStatusListener so jansi related missing class exception will not be shown. (The exception is irrelevant because intellij and windows terminal can already handle ansi color codes)

  • putting jansi jar on the classpath resulted in not colored logs in the output, but in that case the exception was not shown
  • removing true also resulted in monochrome output.
  • It looks like newer windows and also intellij seems to be able to display ansi colored output without any kind of wrapper, so it seems to be safe to add a Noop statusListener so the exception won't be printed during initialization

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

… so jansi related missing class exception will not be shown. (The exception is irrelevant because intellij and windows terminal can already handle ansi color codes)
Copy link
Copy Markdown
Contributor

@taskain7 taskain7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@galovics galovics merged commit 0109d24 into apache:develop Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants