FINERACT-1905: Same day repayment + charge handling improvement#3348
Merged
adamsaghy merged 1 commit intoapache:developfrom Aug 3, 2023
Merged
Conversation
reluxa
reviewed
Aug 3, 2023
| BigDecimal.ZERO, BigDecimal.ZERO, BigDecimal.valueOf(4L), false, null, BigDecimal.ZERO)); | ||
| LoanTransaction loanTransaction = Mockito | ||
| .spy(LoanTransaction.repayment(office, transactionAmount, null, transactionDate, ExternalId.empty())); | ||
| Mockito.when(loanTransaction.getCreatedDate()).thenReturn(Optional.of(OffsetDateTime.of(2023, 1, 1, 1, 1, 1, 1, ZoneOffset.UTC))); |
Contributor
There was a problem hiding this comment.
Do we have testcase where the repayment is added after a charge, and both has a non null createdDate?
reluxa
approved these changes
Aug 3, 2023
adamsaghy
force-pushed
the
FINERACT-1905/same_day_charge_and_repayment_handling
branch
from
011f7af to
6309fad
Compare
adamsaghy
force-pushed
the
FINERACT-1905/same_day_charge_and_repayment_handling
branch
from
6309fad to
93d30b2
Compare
adamsaghy
deleted the
FINERACT-1905/same_day_charge_and_repayment_handling
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.