[FINERACT-1965] Change date resolvement from SMART to STRICT#3352
Merged
taskain7 merged 1 commit intoapache:developfrom Aug 8, 2023
Merged
[FINERACT-1965] Change date resolvement from SMART to STRICT#3352taskain7 merged 1 commit intoapache:developfrom
taskain7 merged 1 commit intoapache:developfrom
Conversation
adamsaghy
reviewed
Aug 2, 2023
...re/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 2, 2023
...re/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 2, 2023
...re/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java
Outdated
Show resolved
Hide resolved
adamsaghy
requested changes
Aug 2, 2023
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please see my comments!
taskain7
force-pushed
the
smart-date-resolvment
branch
from
d51fcfe to
fd3beb7
Compare
adamsaghy
reviewed
Aug 2, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Outdated
Show resolved
Hide resolved
taskain7
force-pushed
the
smart-date-resolvment
branch
from
fd3beb7 to
3e95ba4
Compare
taskain7
force-pushed
the
smart-date-resolvment
branch
from
3e95ba4 to
09c3390
Compare
adamsaghy
reviewed
Aug 4, 2023
fineract-provider/src/main/java/org/apache/fineract/interoperation/util/InteropUtil.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 4, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 4, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 4, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 4, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Outdated
Show resolved
Hide resolved
adamsaghy
reviewed
Aug 4, 2023
integration-tests/src/test/java/org/apache/fineract/integrationtests/DateValidationTest.java
Outdated
Show resolved
Hide resolved
adamsaghy
requested changes
Aug 4, 2023
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please see my comments!
taskain7
force-pushed
the
smart-date-resolvment
branch
6 times, most recently
from
767af72 to
7d36b94
Compare
galovics
requested changes
Aug 8, 2023
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/data/DateFormat.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java
Outdated
Show resolved
Hide resolved
taskain7
force-pushed
the
smart-date-resolvment
branch
3 times, most recently
from
937c1ce to
78f85a4
Compare
galovics
approved these changes
Aug 8, 2023
taskain7
force-pushed
the
smart-date-resolvment
branch
from
78f85a4 to
9225815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changing date resolvement from SMART to STRICT
DateFormat value object has been indtroduced.
DateFormat is used for query parameters at soma API-s.
Extended usage of DateFormat will be coming in further PRs.