Skip to content

FINERACT-1724: Add indexes to assets and jobs#3368

Merged
adamsaghy merged 1 commit intoapache:developfrom
b0c1:FINERACT-1724-Missing-Index
Aug 15, 2023
Merged

FINERACT-1724: Add indexes to assets and jobs#3368
adamsaghy merged 1 commit intoapache:developfrom
b0c1:FINERACT-1724-Missing-Index

Conversation

@b0c1
Copy link
Contributor

@b0c1 b0c1 commented Aug 10, 2023

FINERACT-1724: Add indexes to assets and jobs

  • Add loan_id as indexed field on the m_external_asset_owner_transfer
  • Add job_execution_id as indexed field on the batch_job_execution_params table

Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments!

Copy link
Contributor

@ruchiD ruchiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MySQL builds are failing due to liquibase exception while creating index.
liquibase.exception.DatabaseException: Table 'fineract_default.batch_job_execution_params' doesn't exist. Please check

- [x] Add `loan_id` as indexed field on the `m_external_asset_owner_transfer`
- [x] Add `job_execution_id` as indexed field on the `batch_job_execution_params` table
@adamsaghy adamsaghy force-pushed the FINERACT-1724-Missing-Index branch from 70880be to 0e70e91 Compare August 15, 2023 08:59
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 3a31ee9 into apache:develop Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants