FINERACT-1968: Advanced repayment allocation strategy - data model#3369
Merged
adamsaghy merged 1 commit intoapache:developfrom Aug 11, 2023
Merged
Conversation
adamsaghy
force-pushed
the
FINERACT-1968-Advanced-payment-strategy-model
branch
2 times, most recently
from
54c3641 to
720ba2c
Compare
taskain7
reviewed
Aug 11, 2023
...src/main/java/org/apache/fineract/portfolio/loanproduct/domain/GenericEnumListConverter.java
Outdated
Show resolved
Hide resolved
adamsaghy
force-pushed
the
FINERACT-1968-Advanced-payment-strategy-model
branch
from
720ba2c to
3e5446c
Compare
abraham-menyhart
suggested changes
Aug 11, 2023
Contributor
abraham-menyhart
left a comment
abraham-menyhart
left a comment
There was a problem hiding this comment.
Please see my comments
...rc/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanPaymentAllocationRule.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/fineract/portfolio/loanproduct/domain/LoanProductPaymentAllocationRule.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanPaymentAllocationRule.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/fineract/portfolio/loanproduct/domain/LoanProductPaymentAllocationRule.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanPaymentAllocationRule.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/fineract/portfolio/loanproduct/domain/LoanProductPaymentAllocationRule.java
Outdated
Show resolved
Hide resolved
...an/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/PaymentAllocationType.java
Outdated
Show resolved
Hide resolved
adamsaghy
force-pushed
the
FINERACT-1968-Advanced-payment-strategy-model
branch
from
3e5446c to
ee22193
Compare
adamsaghy
requested review from
abraham-menyhart,
galovics and
taskain7
and removed request for
abraham-menyhart
adamsaghy
force-pushed
the
FINERACT-1968-Advanced-payment-strategy-model
branch
from
ee22193 to
78523c1
Compare
adamsaghy
force-pushed
the
FINERACT-1968-Advanced-payment-strategy-model
branch
2 times, most recently
from
05ecd86 to
12000ee
Compare
- [x] m_loan_product_payment_allocation_rule table created - [x] m_loan_payment_allocation_rule table created - [x] LoanProductPaymentAllocationRule entity - [x] LoanPaymentAllocationRule entity - [x] List of enum converter to String converter to use `AllocationType` list
adamsaghy
force-pushed
the
FINERACT-1968-Advanced-payment-strategy-model
branch
from
12000ee to
d8f95e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FINERACT-1968: Advanced repayment allocation strategy - data model
AllocationTypelist