FINERACT-1932: Add custom Configuration class for transfer service#3373
Merged
galovics merged 1 commit intoapache:developfrom Oct 2, 2023
Merged
Conversation
mmagdiab
force-pushed
the
FINERACT-1932/transfer-module
branch
from
74f40b4 to
018e8e0
Compare
vidakovic
reviewed
Aug 17, 2023
.../src/main/java/org/apache/fineract/portfolio/transfer/starter/TransferAutoConfiguration.java
Outdated
Show resolved
Hide resolved
vidakovic
reviewed
Aug 17, 2023
...pache/fineract/portfolio/transfer/service/TransferWritePlatformServiceJpaRepositoryImpl.java
Outdated
Show resolved
Hide resolved
mmagdiab
changed the title
mmagdiab
force-pushed
the
FINERACT-1932/transfer-module
branch
from
018e8e0 to
6c743dd
Compare
galovics
requested changes
Aug 21, 2023
.../src/main/java/org/apache/fineract/portfolio/transfer/starter/TransferAutoConfiguration.java
Outdated
Show resolved
Hide resolved
mmagdiab
force-pushed
the
FINERACT-1932/transfer-module
branch
from
6c743dd to
72b4558
Compare
mmagdiab
force-pushed
the
FINERACT-1932/transfer-module
branch
from
72b4558 to
94c2979
Compare
galovics
approved these changes
Sep 4, 2023
galovics
changed the title
Contributor
|
@mmagdiab Please kindly rebase this PR with the latest develop branch. The failing tests were already addressed. |
mmagdiab
force-pushed
the
FINERACT-1932/transfer-module
branch
from
94c2979 to
7729a1e
Compare
Contributor
Author
resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.