Skip to content

FINERACT-1932: Add custom Configuration class for shareproduct services#3419

Merged
vidakovic merged 1 commit into
apache:developfrom
mmagdiab:FINERACT-1932/shareproducts-module
Oct 30, 2023
Merged

FINERACT-1932: Add custom Configuration class for shareproduct services#3419
vidakovic merged 1 commit into
apache:developfrom
mmagdiab:FINERACT-1932/shareproducts-module

Conversation

@mmagdiab
Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@adamsaghy
Copy link
Copy Markdown
Contributor

@mmagdiab Please kindly check the below error:

    (see https://errorprone.info/bugpattern/NonApiType)
/home/runner/work/fineract/fineract/fineract-provider/src/main/java/org/apache/fineract/portfolio/shareproducts/starter/ShareProductsConfiguration.java:36: error: [WildcardImport] Wildcard imports, static or otherwise, should not be used
import org.apache.fineract.portfolio.shareproducts.service.*;
^

@mmagdiab mmagdiab force-pushed the FINERACT-1932/shareproducts-module branch from 01a977e to 5cd2c97 Compare September 30, 2023 08:12
@mmagdiab
Copy link
Copy Markdown
Contributor Author

@mmagdiab Please kindly check the below error:

    (see https://errorprone.info/bugpattern/NonApiType)
/home/runner/work/fineract/fineract/fineract-provider/src/main/java/org/apache/fineract/portfolio/shareproducts/starter/ShareProductsConfiguration.java:36: error: [WildcardImport] Wildcard imports, static or otherwise, should not be used
import org.apache.fineract.portfolio.shareproducts.service.*;
^

resolved

@mmagdiab mmagdiab force-pushed the FINERACT-1932/shareproducts-module branch from 5cd2c97 to 9397b7e Compare October 3, 2023 10:14
@vidakovic
Copy link
Copy Markdown
Contributor

@mmagdiab could you please resolve these conflicts?

@mmagdiab mmagdiab force-pushed the FINERACT-1932/shareproducts-module branch from 9397b7e to b1e5ecd Compare October 28, 2023 15:35
@mmagdiab
Copy link
Copy Markdown
Contributor Author

Conflicts resolved.

Copy link
Copy Markdown
Contributor

@vidakovic vidakovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vidakovic vidakovic merged commit 0b1ca2d into apache:develop Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants