FINERACT-1991: Added search feature to antora generated documentation site #3494
FINERACT-1991: Added search feature to antora generated documentation site #3494jogathogo wants to merge 3 commits intoapache:developfrom
Conversation
|
See screencast below for a preview of the feature Screen.Recording.2023-10-09.at.17.12.04.mov |
|
@jogathogo builds are failing with the following: Apache Rat audit failure - 421 unapproved licenses, please check and fix this. |
|
Please don't merge this one before we've created release 1.9.0. Let's target 1.10.0. Jira tickets updated. |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
|
Bringing some side conversations back to this PR, see below Hello James, I managed to run RAT which identified the licenses it deems Therefore I think we can go ahead. Let me know what you think. Copyright (c) Felix Böhm Redistribution and use in source and binary forms, with or without Redistributions of source code must retain the above copyright notice, Redistributions in binary form must reproduce the above copyright THIS IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND |
|
If this is the only rat error, then yes I think this is a BSD clause 2 and therefore a Category A license https://www.apache.org/legal/resolved.html#category-a Github should tell you what license it is. Sent from Gmail Mobile |
@vidakovic now that 1.9 is out, can we resume this? This PR is purely documentation related and does not contain any fineract code and therefore should be safe to merge without breaking anything. |
|
I would like to commit this. |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.