FINERACT-1992: Multi-dlnqcy - Configuration of Installment level deli…#3510
Merged
adamsaghy merged 1 commit intoOct 18, 2023
Conversation
Contributor
|
@josehernandezfintecheandomx can we use the full name of "delinquency" instead of "dlqncy"? Other than that, looks good. |
ruchiD
reviewed
Oct 16, 2023
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_installment_dlnqcy
branch
from
7e5dd26 to
a89fd0e
Compare
Contributor
Author
@galovics It has been renamed as you suggested. Thanks |
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_installment_dlnqcy
branch
from
a89fd0e to
4f7b51d
Compare
ruchiD
reviewed
Oct 17, 2023
Contributor
ruchiD
left a comment
ruchiD
left a comment
There was a problem hiding this comment.
hi @josehernandezfintecheandomx,
- Please confirm whether avro schema changes are also needed for this configuration at this point.
- Please also add required swagger changes for LoanProductApi.
- Rest looks good to me.
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_installment_dlnqcy
branch
from
4f7b51d to
c865b30
Compare
Contributor
Author
Yes all of them has been updated |
ruchiD
reviewed
Oct 17, 2023
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_installment_dlnqcy
branch
from
c865b30 to
eabddf8
Compare
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_installment_dlnqcy
branch
from
eabddf8 to
841bdca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nquency
Description
Multi-dlnqcy - Configuration of Installment level delinquency, at Loan Product level we have added a flag to Enable / Disable the Installment Level Delinquency
FINERACT-1992
Flag inherit from Loan Product to Loan entity at request time
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.