FINERACT-1761: Loan Product repayment due event values set by default…#3546
Closed
josehernandezfintecheandomx wants to merge 1 commit intoapache:developfrom
Conversation
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_repayment_events_global_settings
branch
6 times, most recently
from
13c1757 to
ab62a81
Compare
… from global configurations
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_repayment_events_global_settings
branch
from
ab62a81 to
fdb930b
Compare
Contributor
Author
|
TLDR... Not needed it more |
1 similar comment
Contributor
Author
|
TLDR... Not needed it more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… from global configurations
Description
As part of Loan Product enhancements in the create and edit actions some values are being used from the Global Configuration. In particular the Event (notifications) settings values, so those values must to be remarked to indicated the default value is set from the GLobal Configuration
FINERACT-1761
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.