FINERACT-1992: Multi Delinquency event for installment range change#3610
Merged
adamsaghy merged 1 commit intoapache:developfrom Nov 30, 2023
Conversation
reluxa
reviewed
Nov 29, 2023
Contributor
There was a problem hiding this comment.
Shall we raise an event also if the ranges are not changed just the amount?
reluxa
reviewed
Nov 29, 2023
ruchiD
force-pushed
the
FINERACT-1992-Multi-Deliquency-event-for-installment-range-change
branch
from
fd43679 to
a7befb0
Compare
reluxa
reviewed
Nov 30, 2023
| } | ||
| } | ||
| // remove tags for non existing installments that got deleted due to re-schedule | ||
| removeDelinquencyTagsForNonExistingInstallments(loan.getId()); |
Contributor
There was a problem hiding this comment.
If an installment is deleted and we delete the related delinquency installment, then we might also want to raise an event, don't we?
Contributor
Author
There was a problem hiding this comment.
These installments are non existing for the loan. Reschedule/Disbursal flow creates new installments for loan and deletes previous ones for loan, but tags for old non existing installments exits and needs to be cleaned up. No need to raise event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change made to emit range change event for installment level range changes.
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.