FINERTACT-1981: Advanced payment allocation fixes for Loan Schedule#3611
Merged
adamsaghy merged 1 commit intoapache:developfrom Dec 19, 2023
Conversation
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_adv_pment_alloc_validation
branch
from
5f556c5 to
711d89f
Compare
Contributor
Author
Integration Test case added |
adamsaghy
reviewed
Nov 30, 2023
Contributor
There was a problem hiding this comment.
Please change the description accordingly what the test is testing
Contributor
Author
There was a problem hiding this comment.
Done!
adamsaghy
reviewed
Nov 30, 2023
Contributor
There was a problem hiding this comment.
Please throw unique error code supported.only.for.progressive.loan.schedule.handling is already been used elsewhere for other purposes!
Contributor
Author
There was a problem hiding this comment.
Done!
adamsaghy
reviewed
Nov 30, 2023
...org/apache/fineract/integrationtests/AdvancedPaymentAllocationLoanRepaymentScheduleTest.java
Outdated
Show resolved
Hide resolved
adamsaghy
requested changes
Nov 30, 2023
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Please see my comments!
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_adv_pment_alloc_validation
branch
from
711d89f to
3417d61
Compare
Contributor
Author
Comments resolved |
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_adv_pment_alloc_validation
branch
2 times, most recently
from
b55a57b to
2ccefdf
Compare
josehernandezfintecheandomx
changed the title
Contributor
|
@josehernandezfintecheandomx Please check the failing tests! |
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_adv_pment_alloc_validation
branch
3 times, most recently
from
96d7a0f to
b69f97d
Compare
adamsaghy
changed the title
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_adv_pment_alloc_validation
branch
3 times, most recently
from
6d3face to
3cf4b53
Compare
Contributor
|
@josehernandezfintecheandomx Please check and fix the failing test cases! |
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_adv_pment_alloc_validation
branch
from
3cf4b53 to
9392b05
Compare
adamsaghy
reviewed
Dec 14, 2023
Contributor
There was a problem hiding this comment.
For backward compatibility, the loan schedule type is optional. So it might not be sent, in that case the CUMULATIVE is the fallback default value. You might wanna mimic that behaviour here as well.
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_adv_pment_alloc_validation
branch
from
9392b05 to
fb2774a
Compare
josehernandezfintecheandomx
force-pushed
the
enhancement/loan_product_adv_pment_alloc_validation
branch
from
fb2774a to
c15540c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…essive loan disbursement handling
Description
Advanced payment allocation should only support Progressive loan disbursement handling, so we needed to add a validation in the API
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.