FINERACT-1932: Fineract modularization - fineract-savings#3634
Conversation
There was a problem hiding this comment.
This looks a breaking change to me
There was a problem hiding this comment.
Done! the code has been updated to the service InteropServiceImpl
|
@josehernandezfintecheandomx Please find a way to fetch the Notes into the InterOpData as without it, it is a breaking change. Please also check the spotless failures! |
josehernandezfintecheandomx
force-pushed
the
enhancement/fineract_savings_module
branch
from
52bff62 to
8288542
Compare
Done both things! @adamsaghy |
...ct-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@josehernandezfintecheandomx Please check my comments and please modify the PR title and the commit message: Fineract modularisation tracked in this story: https://issues.apache.org/jira/browse/FINERACT-1932 Please use this in the PR and in the commit message! |
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
@josehernandezfintecheandomx Please check my comments and please modify the PR title and the commit message:
Fineract modularisation tracked in this story: https://issues.apache.org/jira/browse/FINERACT-1932
Please use this in the PR and in the commit message!
josehernandezfintecheandomx
changed the title
josehernandezfintecheandomx
force-pushed
the
enhancement/fineract_savings_module
branch
from
8288542 to
eeba2b1
Compare
@adamsaghy Done both things requested, Thanks! |
2 participants
Description
Create the initial fineract-savings module - used to savings products and accounts module classes and interfaces
FINERACT-1932
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.