Skip to content

JMeter test suite for Fineract banking operations#3746

Closed
anjiltech wants to merge 3 commits intoapache:developfrom
anjiltech:jmeter-suite
Closed

JMeter test suite for Fineract banking operations#3746
anjiltech wants to merge 3 commits intoapache:developfrom
anjiltech:jmeter-suite

Conversation

@anjiltech
Copy link

Description

Created JMeter test suits for performing Fineract based banking setup and transaction operations along with scripts for running the test suites

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

…ProcessingStrategyCode instead of transactionProcessingStrategyId to work with 1.9.0 and later versions
Copy link
Contributor

@galovics galovics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjiltech I'm still not convinced this is something we need at this point.

  1. JMeter is not for functional testing.
  2. The AccountNum.csv file is super fishy and shouldn't be there at all. Why can't we generate account numbers?
  3. By the looks of it the test suite is not reproducible; i.e. you can't run it twice for the same fineract instance since the account ids are hardcoded (see point 2)
  4. The suite assumes read/write separation which isn't always the case.

@anjiltech
Copy link
Author

hi @galovics ,

Regarding Point No. 2 above, It was kept in that format to be able to run a highly concurrent user requests all working across different account numbers at a time (Say 1000 concurrent requests with each request working on different account number at a time). The use CSV config file helps achieving the unique account numbers to be used across different threads. This can be simplified to just create and use account numbers from within the JMeter suite for a relatively lower concurrent user requests.

Point 3. The transactions can be performed repetitively. In its current format it expects to clear the data and re-run. By simplifying the format of usage in Point 2, this behavior will change.

Point 4. By default both read and write points to same IP and it works against the single instance Fineract without Read/Write seperation. I have added the provision to be able to work with a Read/Write seperated setup, in which case, user can specify a different IP for those two instances.

With further simplified version, we can change behavior to overcome the observations you mentioned in 2 and 3 above.

@github-actions
Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Mar 15, 2024
@github-actions github-actions bot closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants