gsim and glim functionalities added #445
Conversation
nikpawar89
force-pushed
the
GLIM_GSIM_enhancement
branch
from
ca70598 to
0c46b9d
Compare
nikpawar89
force-pushed
the
GLIM_GSIM_enhancement
branch
from
0c46b9d to
a4b570c
Compare
avikganguly01
left a comment
avikganguly01
left a comment
There was a problem hiding this comment.
Looks good to me other than some files being unreviewable. I would like to see how the APIs are being used. Can you point me to your community-app PR?
| UNIQUE INDEX `gsim_account_no_UNIQUE` (`account_number`), | ||
| INDEX `FK_gsim_group_id` (`group_id`), | ||
| CONSTRAINT `FK_gsim_group_id` FOREIGN KEY (`group_id`) REFERENCES `m_group` (`id`) | ||
| ) COLLATE='utf8_general_ci' ENGINE=InnoDB AUTO_INCREMENT=1; |
There was a problem hiding this comment.
Please remove collate, engine and auto increment specifications from the migration scripts.
| import com.google.gson.JsonArray; | ||
| import com.google.gson.JsonElement; | ||
|
|
||
| @Service |
There was a problem hiding this comment.
Unreviewable code. Please make sure file diff for existing files is readable by changing only parts which you intend to change.
There was a problem hiding this comment.
this has been due to squash I performed to merge several commits, I will get it corrected
| if(isGsim && (deposit.getId()!=null)) | ||
| { | ||
| GroupSavingsIndividualMonitoring gsim=gsimRepository.findOne(account.getGsim().getId()); | ||
| System.out.println("parent deposit "+gsim.getParentDeposit()); |
There was a problem hiding this comment.
Move to slf4j logger debug level if you wish to log something for debugging purposes.
| import org.apache.fineract.accounting.common.AccountingConstants.SAVINGS_PRODUCT_ACCOUNTING_PARAMS; | ||
|
|
||
| public class DepositsApiConstants { | ||
|
|
There was a problem hiding this comment.
will get it corrected
|
For community app, I will have to prepare PR, by getting out gsim and gsim code.. will try get it out soon. Meanwhile we can work on getting this merged |
|
@edcable, @avikganguly01 and @nikpawar89 , How soon can this be merged into Fineract including community-app side. It seems we have a need for this, please advice |
|
@nikpawar89 , @avikganguly01 , |
|
@nikpawar89 thank you very much for your interest in and contribution to Fineract/Mifos! I'm an (old) volunteer who got reminded of Mifos/Fineract this week-end at the FOSDEM conference, and I'm taking a moment to help the project clean up some of it's old issues and pull requests etc. We were wondering whether you are still alive, and would be willing to @francisguchie @Ippezrobert this needs someone to rebase and resolve conflicts, if you could do that, or find someone who could, then I'm sure other committers (probably not myself) would gladly merge this. /Cc FYI @apache/fineract-committers |
|
Friendly service reminder: I will close this PR in 3 days to help this project have a clean list of active PRs. |
|
@vorburger , Me and @nikpawar have been discussing about this today. He is still alive and will be responding soon on this. |
|
this PR is being handled in PR: |
5 participants
GLIM and GSIM functionalities