Skip to content

FINERACT-2251: Delinquency Management (org.apache.fineract.portfolio.…#4655

Closed
oleksma wants to merge 1 commit intoapache:developfrom
oleksma:FINERACT-2169/subtask-FINERACT-2251-Delinquency-Management-(org.apache.fineract.portfolio.delinquency)
Closed

FINERACT-2251: Delinquency Management (org.apache.fineract.portfolio.…#4655
oleksma wants to merge 1 commit intoapache:developfrom
oleksma:FINERACT-2169/subtask-FINERACT-2251-Delinquency-Management-(org.apache.fineract.portfolio.delinquency)

Conversation

@oleksma
Copy link
Copy Markdown
Contributor

@oleksma oleksma commented May 9, 2025

Refactoring done:
Applied approach "New command processing"
New dto applied *Request, *Response
Refactored validation: applied jakarta validation, removed validator
Applied Lombok

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@oleksma oleksma force-pushed the FINERACT-2169/subtask-FINERACT-2251-Delinquency-Management-(org.apache.fineract.portfolio.delinquency) branch 8 times, most recently from 0973a31 to 69a4c44 Compare May 13, 2025 17:47
@oleksma oleksma force-pushed the FINERACT-2169/subtask-FINERACT-2251-Delinquency-Management-(org.apache.fineract.portfolio.delinquency) branch from 69a4c44 to d7c0ebe Compare May 16, 2025 08:56
@github-actions
Copy link
Copy Markdown

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Jun 16, 2025
@github-actions github-actions bot closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant