FINERACT-2279: Contract Termination feature#4669
Closed
alberto-art3ch wants to merge 1 commit intoapache:developfrom
Closed
FINERACT-2279: Contract Termination feature#4669alberto-art3ch wants to merge 1 commit intoapache:developfrom
alberto-art3ch wants to merge 1 commit intoapache:developfrom
Conversation
alberto-art3ch
force-pushed
the
FINERACT-2279/contract-termination-transaction
branch
3 times, most recently
from
30b632d to
720fbbf
Compare
| } else if (CommandParameterUtil.is(commandParam, "assigndelinquency")) { | ||
| commandRequest = builder.assignDelinquency(resolvedLoanId).build(); | ||
| } else if (CommandParameterUtil.is(commandParam, LoanApiConstants.CONTRACT_TERMINATION_COMMAND)) { | ||
| commandRequest = builder.applyContractTermination(loanId).build(); |
Contributor
There was a problem hiding this comment.
Perhaps it is better to use resolvedLoanId instead of loanId here?
Contributor
Author
There was a problem hiding this comment.
Done! Code updated, Thanks @mariiaKraievska
alberto-art3ch
force-pushed
the
FINERACT-2279/contract-termination-transaction
branch
from
720fbbf to
363b025
Compare
oleksii-novikov-onix
approved these changes
May 19, 2025
alberto-art3ch
force-pushed
the
FINERACT-2279/contract-termination-transaction
branch
from
363b025 to
38ad5a7
Compare
| public boolean isContractTermination() { | ||
| return LoanTransactionType.CONTRACT_TERMINATION.equals(getTypeOf()) && isNotReversed(); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I think isNonMonetaryTransaction() method should also be adjusted
| return Calls.ok(FineractClientHelper.getFineractClient().loanTransactions.executeLoanTransaction(loanId, request, "repayment")); | ||
| } | ||
|
|
||
| public PostLoansLoanIdTransactionsResponse executeLoanTransaction(final Long loanId, final PostLoansLoanIdTransactionsRequest request, |
Contributor
There was a problem hiding this comment.
This method is not used anywhere. Is it really needed?
| CAPITALIZED_INCOME(35, "loanTransactionType.capitalizedIncome"), // | ||
| CAPITALIZED_INCOME_AMORTIZATION(36, "loanTransactionType.capitalizedIncomeAmortization"), // | ||
| // Kind of Final Transactions | ||
| CONTRACT_TERMINATION(90, "loanTransactionType.contractTermination"), // |
Contributor
There was a problem hiding this comment.
It's a stupid question, but why 90? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We will be able to initiate
Contract Terminationon the any active,progressiveloan. We will be able to do Contract Termination on a active loan through API. A non-monetary transaction will be created as of the current date when the contract termination is doneThese are some of the features with this new Loan substatus
CONTRACT_TERMINATIONPrincipal Outstanding + Calculated Interest outstanding + outstanding charges as of current date will be the Contract termination amount
Charge-off is allowed on the Terminated loan accounts, but contract termination is not supported on charged-off loans!
Chargebacks are allowed on Terminated loan accounts
Loan status remains ACTIVE, but set sub-status to “CONTRACT_TERMINATED”
New external business event
LoanContractTerminationPostBusinessEventFINERACT-2279
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.