FINERACT-2202: Bulk import fix#4702
Closed
RamsesCamacho1171 wants to merge 1 commit intoapache:developfrom
Closed
Conversation
fdd373d to
c71de36
Compare
Contributor
Author
|
Hello @adamsaghy , we uploaded changes for the bulk part, some tests failed and I wanted to know if what we changed is what caused the tests to fail. |
adamsaghy
reviewed
May 29, 2025
| } | ||
|
|
||
| if (isAddressEnabled) { | ||
| ObjectMapper mapper = new ObjectMapper(); |
Contributor
There was a problem hiding this comment.
This looks incorrect to me...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FINERACT-2202: Bulk import fix
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.