Skip to content

FINERACT-2202: Bulk import fix#4702

Closed
RamsesCamacho1171 wants to merge 1 commit intoapache:developfrom
danielales2541:qa-new-loan-saving
Closed

FINERACT-2202: Bulk import fix#4702
RamsesCamacho1171 wants to merge 1 commit intoapache:developfrom
danielales2541:qa-new-loan-saving

Conversation

@RamsesCamacho1171
Copy link
Contributor

Description

FINERACT-2202: Bulk import fix

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@RamsesCamacho1171
Copy link
Contributor Author

Hello @adamsaghy , we uploaded changes for the bulk part, some tests failed and I wanted to know if what we changed is what caused the tests to fail.

}

if (isAddressEnabled) {
ObjectMapper mapper = new ObjectMapper();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks incorrect to me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants