Skip to content

FINERACT-2301: New command processing - Client collateral management#4753

Closed
oleksma wants to merge 1 commit intoapache:developfrom
oleksma:FINERACT-2301/New-command-processing---Client-collateral-management
Closed

FINERACT-2301: New command processing - Client collateral management#4753
oleksma wants to merge 1 commit intoapache:developfrom
oleksma:FINERACT-2301/New-command-processing---Client-collateral-management

Conversation

@oleksma
Copy link
Contributor

@oleksma oleksma commented Jun 9, 2025

  1. new *Request, *Response dto
  2. validation annotations in *Request, messages in bundles
  3. new handlers
  4. Refactored service layer methods

Description

Describe the changes made and why they were made.

Ignore if these details are present on the associated Apache Fineract JIRA ticket.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@oleksma
Copy link
Contributor Author

oleksma commented Jun 9, 2025

This PR in status Draft, because is waiting common classes with functionality validation , security , etc from PR
[FINERACT-2238: Refactor under new concept business date api]
#4632

@oleksma oleksma force-pushed the FINERACT-2301/New-command-processing---Client-collateral-management branch 7 times, most recently from 6955145 to 1bcf208 Compare June 10, 2025 20:41
@oleksma oleksma force-pushed the FINERACT-2301/New-command-processing---Client-collateral-management branch from 1bcf208 to 32a9cd2 Compare June 11, 2025 15:23
@github-actions
Copy link

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label Jul 12, 2025
@github-actions github-actions bot closed this Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant