FINERACT-2421: Manual interest refund on closed loan generates exception

[alberto-art3ch]

Description

We have run into a bug with creating manual interest refunds for Loan accounts. Upon creating a manual interest refund for a loan in 600 (CLOSED_OBLIGATIONS_MET) status, we are receiving a 403 DatabaseException because the Accrual Activity transaction was being created with transaction date in null

FINERACT-2421

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[adamsaghy]

this seems odd for fixing the issue. Can you please elaborate why this helps?

[alberto-art3ch]

The DatabaseException was because in the AccrualActivity process, the closureDate was set in null because the loanBalanceService.isOverPaid(loan) return true but the Loan instance was not set as Overpaid status

LocalDate closureDate = loanBalanceService.isOverPaid(loan) ? loan.getOverpaidOnDate() : loan.getClosedOnDate();

So, If we set the Loan transition we are ensuring the Loan has the right status and this case the OverpaidOnDate value need to set the closureDate

[adamsaghy]

LGTM