Skip to content

FINERACT-2446: Tax Group and Tax Component APIs return HTTP 500 when …#5371

Merged
adamsaghy merged 2 commits intoapache:developfrom
TECHSERVICES-LIMITED:bugfix/FINERACT-2446
Jan 26, 2026
Merged

FINERACT-2446: Tax Group and Tax Component APIs return HTTP 500 when …#5371
adamsaghy merged 2 commits intoapache:developfrom
TECHSERVICES-LIMITED:bugfix/FINERACT-2446

Conversation

@oluexpert99
Copy link
Contributor

…no record is found (empty result), instead of returning a proper HTTP 404 Not Found

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

…no record is found (empty result), instead of returning a proper HTTP 404 Not Found
Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach proper testing!
Probably E2E testing would be the best!

…no record is found (empty result), instead of returning a proper HTTP 404 Not Found
@oluexpert99
Copy link
Contributor Author

Please attach proper testing! Probably E2E testing would be the best!

Done . I have added test

@oluexpert99 oluexpert99 requested a review from adamsaghy January 23, 2026 15:16
@adamsaghy adamsaghy merged commit e9dfc4a into apache:develop Jan 26, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants