Skip to content

FINERACT-2165: Use "Fineract-client-feign" in integration tests#5570

Merged
adamsaghy merged 1 commit intoapache:developfrom
edk12564:FINERACT-2165-CurrencyTest
Mar 2, 2026
Merged

FINERACT-2165: Use "Fineract-client-feign" in integration tests#5570
adamsaghy merged 1 commit intoapache:developfrom
edk12564:FINERACT-2165-CurrencyTest

Conversation

@edk12564
Copy link
Contributor

@edk12564 edk12564 commented Mar 2, 2026

JIRA: FINERACT-2165

Changes

CurrenciesTest utilized the low level RestAssured client and JUnit. According to the guidelines in the Fineract community and similar tests in the codebase, I replaced these tests with equivalent tests in Feign Client, Cucumber and Gherkin. More details below.

  • Eliminated old CurrenciesTest, CurrenciesHelper, and CurrencyDomain due to implementing RestAssured client and JUnit
  • Created test steps with Feign Client and feature file with Gherkin that covers same test cases as old tests but now located in E2E-core and E2E-runner and updated tooling.
  • Updated ErrorMessageHelper to handle Currency error logging.
  • Fixed bug in CenterDomain.java that was causing compilation issues. CurrenciesDomain was improperly being imported and not used anywhere.

Results

Tests pass with the latest version of the codebase.

Screenshot 2026-03-01 at 6 53 16 PM

After a clean build, grep shows no project files with references to CurrenciesTest, CurrenciesHelper, or CurrencyDomain.

Screenshot 2026-03-02 at 2 52 47 AM

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@edk12564 edk12564 force-pushed the FINERACT-2165-CurrencyTest branch from 5f91352 to 6464726 Compare March 2, 2026 01:13
@edk12564 edk12564 changed the title FINERACT-2165: Refactored Currency Tests to use Cucumber and Feign Client FINERACT-2165: Use "Fineract-client-feign" in integration tests Mar 2, 2026
- Eliminated old CurrenciesTest, CurrenciesHelper, and CurrencyDomain due to implementing RestAssured client and JUnit
- Created test steps and Gherkin that covers same items as old tests but in E2E-core and E2E-runner.
- Updated ErrorMessageHelper to handle Currency errors.
- Fixed bug in CenterDomain.java that was causing compilation issues. CurrenciesDomain was improperly being imported and not used anywhere.
@edk12564 edk12564 force-pushed the FINERACT-2165-CurrencyTest branch from 6464726 to bb2acdb Compare March 2, 2026 09:02
@adamsaghy adamsaghy merged commit 4876c9e into apache:develop Mar 2, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants