FINERACT-2523: Fix inconsistent interest recalculation for cumulative loans with floating rates#5593
Open
DeathGun44 wants to merge 1 commit intoapache:developfrom
Conversation
… loans with floating rates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LoanApplicationTerms.updateAnnualNominalInterestRate()did not invalidate the cachedfixedEmiAmountwhen the interest rate changed. This caused exact repayments on cumulative loans with floating rates to only adjust the last installment, while overpayments correctly recalculated all future installments.Fix: Reset
fixedEmiAmount = nullwhen the annual nominal interest rate actually changes, forcing EMI recalculation for all subsequent installments.Added integration test to verify the fix with both exact repayment and overpayment scenarios.
Checklist