Skip to content

FINERACT-2523: Fix inconsistent interest recalculation for cumulative loans with floating rates#5593

Open
DeathGun44 wants to merge 1 commit intoapache:developfrom
DeathGun44:FINERACT-2523/fix-floating-rate-interest-recalculation
Open

FINERACT-2523: Fix inconsistent interest recalculation for cumulative loans with floating rates#5593
DeathGun44 wants to merge 1 commit intoapache:developfrom
DeathGun44:FINERACT-2523/fix-floating-rate-interest-recalculation

Conversation

@DeathGun44
Copy link
Contributor

@DeathGun44 DeathGun44 commented Mar 6, 2026

Description

LoanApplicationTerms.updateAnnualNominalInterestRate() did not invalidate the cached fixedEmiAmount when the interest rate changed. This caused exact repayments on cumulative loans with floating rates to only adjust the last installment, while overpayments correctly recalculated all future installments.

Fix: Reset fixedEmiAmount = null when the annual nominal interest rate actually changes, forcing EMI recalculation for all subsequent installments.

Added integration test to verify the fix with both exact repayment and overpayment scenarios.

Checklist

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant