FINERACT-2521 Loan status is Active instead of Closed after pay-off re-amortized loan with equal interest split and fee charge#5602
Open
ap200506-sudo wants to merge 1 commit intoapache:developfrom
Conversation
IOhacker
requested changes
Mar 9, 2026
| loanAccountService.saveLoanTransactionWithDataIntegrityViolationChecks(newRepaymentTransaction); | ||
| loan = loanAccountService.saveAndFlushLoanWithDataIntegrityViolationChecks(loan); | ||
|
|
||
| // FIX: trigger loan lifecycle transition |
Contributor
There was a problem hiding this comment.
Remove the comment, squash and commit after the change.
Contributor
|
@ap200506-sudo verify the suggestion sent in the Apache Fineract list and review the Github Actions output logs |
Contributor
|
@ap200506-sudo Please review and fix the failing test cases and checks! |
…e-amortized loan with equal interest split and fee charge
fd9f681 to
7480331
Compare
Contributor
Author
|
Made the changes and squash and committed |
Contributor
|
@ap200506-sudo Please check the failing tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the loan status remained Active instead of Closed after full pay-off of a re-amortized loan with equal interest split and fee charge.
Jira: FINERACT-2521