Skip to content

FINERACT-2521 Loan status is Active instead of Closed after pay-off re-amortized loan with equal interest split and fee charge#5602

Open
ap200506-sudo wants to merge 1 commit intoapache:developfrom
ap200506-sudo:fix-loan-status-after-payoff
Open

FINERACT-2521 Loan status is Active instead of Closed after pay-off re-amortized loan with equal interest split and fee charge#5602
ap200506-sudo wants to merge 1 commit intoapache:developfrom
ap200506-sudo:fix-loan-status-after-payoff

Conversation

@ap200506-sudo
Copy link
Contributor

Fixes an issue where the loan status remained Active instead of Closed after full pay-off of a re-amortized loan with equal interest split and fee charge.

Jira: FINERACT-2521

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review my comments

loanAccountService.saveLoanTransactionWithDataIntegrityViolationChecks(newRepaymentTransaction);
loan = loanAccountService.saveAndFlushLoanWithDataIntegrityViolationChecks(loan);

// FIX: trigger loan lifecycle transition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comment, squash and commit after the change.

@IOhacker
Copy link
Contributor

IOhacker commented Mar 9, 2026

@ap200506-sudo verify the suggestion sent in the Apache Fineract list and review the Github Actions output logs

@adamsaghy
Copy link
Contributor

@ap200506-sudo Please review and fix the failing test cases and checks!

…e-amortized loan with equal interest split and fee charge
@ap200506-sudo ap200506-sudo force-pushed the fix-loan-status-after-payoff branch from fd9f681 to 7480331 Compare March 9, 2026 10:40
@ap200506-sudo ap200506-sudo requested a review from IOhacker March 9, 2026 10:40
@ap200506-sudo
Copy link
Contributor Author

Made the changes and squash and committed

@adamsaghy
Copy link
Contributor

@ap200506-sudo Please check the failing tests

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':fineract-provider:spotlessJavaCheck'.
> The following files had format violations:
      src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java
          @@ -276,7 +276,6 @@
           ········loanAccountService.saveLoanTransactionWithDataIntegrityViolationChecks(newRepaymentTransaction);
           ········loan·=·loanAccountService.saveAndFlushLoanWithDataIntegrityViolationChecks(loan);
           
          -
           ········loanLifecycleStateMachine.determineAndTransition(loan,·transactionDate);
           
           ········if·(StringUtils.isNotBlank(noteText))·{
  Run './gradlew :fineract-provider:spotlessApply' to fix these violations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants