Skip to content

FINERACT-2501: Collaborative API Standardization - Savings Module#5617

Open
Ambika-Sony wants to merge 1 commit intoapache:developfrom
Ambika-Sony:FINERACT-2501-collab
Open

FINERACT-2501: Collaborative API Standardization - Savings Module#5617
Ambika-Sony wants to merge 1 commit intoapache:developfrom
Ambika-Sony:FINERACT-2501-collab

Conversation

@Ambika-Sony
Copy link
Contributor

…## Description
This PR is part of the collaboration with Edward Kang (@edk12564) on FINERACT-2501.

Changes:

  • Standardized operationIds in SavingsAccountsApiResource.java to follow the methodName + Entity + Description convention.
  • Restored logic in the Savings module that was accidentally deleted during a previous conflict resolution.
  • Updated SavingsAccountsExternalIdTest.java to match new operation names.

Note on Build:

The local build is currently failing due to dependency issues in the Teller/Cashier module (outside the scope of my Savings work). I am opening this PR to sync my changes before my university exams. I will resolve the merge conflicts and build errors once I return in a few days.

  • [x ] Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • [ x] Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

…hod names

- added operationIds to every deduplicated feign method currently in use
- added to Savings module as well
- added to self serve savings module as well (might be deleted later)
@adamsaghy
Copy link
Contributor

@Ambika-Sony Please rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants