FINERACT-1152: Loan Rescheduling End Date Validation Fix#5619
Open
DeathGun44 wants to merge 1 commit intoapache:developfrom
Open
FINERACT-1152: Loan Rescheduling End Date Validation Fix#5619DeathGun44 wants to merge 1 commit intoapache:developfrom
DeathGun44 wants to merge 1 commit intoapache:developfrom
Conversation
Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves FINERACT-1152.
The core issue here was that you couldn't extend a loan's tenure (
extraTerms) and change its EMI at the same time because the validation threw an error if the newendDatedidn't already exist in the schedule.What I changed:
extraTerms > 0, we allow theendDateto fall on a future, projected installment date.isSpecificToInstallment=false). Now, the schedule generator will naturally apply the new EMI across all future installments, including the newly requested ones.emiandendDatefields for rescheduling requests. I added them in, regenerated thefineract-clientSDK, and then wrote a modern integration test (testCreateLoanRescheduleChangeEMIWithExtraTerms) bypassing the legacy RestAssured models to prove the fix works perfectly!Checklist