FINERACT-2535: Data type 'BOOLEAN' is not supported in runreports endpoint#5637
FINERACT-2535: Data type 'BOOLEAN' is not supported in runreports endpoint#5637leonardoalunno wants to merge 1 commit intoapache:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes MySQL report column type resolution so that columns reported as BOOLEAN (and BOOL) are recognized by the runreports/data-queries type mapping logic instead of throwing “Data type 'BOOLEAN' is not supported”.
Changes:
- Extend MySQL dialect type aliases for
JdbcJavaType.BOOLEANto includeBOOLEAN(andBOOL). - Add unit tests covering MySQL resolution for
BOOLEAN,BOOL, andBITtype names.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JdbcJavaType.java | Adds BOOLEAN (and BOOL) as accepted MySQL type-name aliases for the BOOLEAN mapping. |
| fineract-core/src/test/java/org/apache/fineract/infrastructure/core/service/database/JdbcJavaTypeTest.java | Introduces tests ensuring MySQL resolves BOOLEAN/BOOL/BIT to JdbcJavaType.BOOLEAN. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
adamsaghy
left a comment
There was a problem hiding this comment.
Can you write an integration test which tests whether the reported report can be executed successfully?
6cf0200 to
080057a
Compare
080057a to
1fc714b
Compare
1fc714b to
a3ecd7c
Compare
Thanks for the review. |
Description
Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.