Skip to content

FINERACT-2535: Data type 'BOOLEAN' is not supported in runreports endpoint#5637

Open
leonardoalunno wants to merge 1 commit intoapache:developfrom
leonardoalunno:FINERACT-2535-boolean-runreports
Open

FINERACT-2535: Data type 'BOOLEAN' is not supported in runreports endpoint#5637
leonardoalunno wants to merge 1 commit intoapache:developfrom
leonardoalunno:FINERACT-2535-boolean-runreports

Conversation

@leonardoalunno
Copy link

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Copilot AI review requested due to automatic review settings March 16, 2026 19:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes MySQL report column type resolution so that columns reported as BOOLEAN (and BOOL) are recognized by the runreports/data-queries type mapping logic instead of throwing “Data type 'BOOLEAN' is not supported”.

Changes:

  • Extend MySQL dialect type aliases for JdbcJavaType.BOOLEAN to include BOOLEAN (and BOOL).
  • Add unit tests covering MySQL resolution for BOOLEAN, BOOL, and BIT type names.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JdbcJavaType.java Adds BOOLEAN (and BOOL) as accepted MySQL type-name aliases for the BOOLEAN mapping.
fineract-core/src/test/java/org/apache/fineract/infrastructure/core/service/database/JdbcJavaTypeTest.java Introduces tests ensuring MySQL resolves BOOLEAN/BOOL/BIT to JdbcJavaType.BOOLEAN.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write an integration test which tests whether the reported report can be executed successfully?

@leonardoalunno leonardoalunno force-pushed the FINERACT-2535-boolean-runreports branch 3 times, most recently from 6cf0200 to 080057a Compare March 17, 2026 15:36
@leonardoalunno leonardoalunno force-pushed the FINERACT-2535-boolean-runreports branch from 080057a to 1fc714b Compare March 17, 2026 17:20
@leonardoalunno leonardoalunno force-pushed the FINERACT-2535-boolean-runreports branch from 1fc714b to a3ecd7c Compare March 17, 2026 21:16
@leonardoalunno
Copy link
Author

Can you write an integration test which tests whether the reported report can be executed successfully?

Thanks for the review.
I added an integration test shouldExecuteReportSuccessfullyWhenReportContainsBooleanColumn() that creates a report with a BOOLEAN column and verifies successful execution via the runreports endpoint.
I also adjusted the SQL used by the test to be cross-database compatible and hardened cleanup behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants