Skip to content

FINERACT-2455: Working Capital Loan action templates#5656

Merged
adamsaghy merged 1 commit intoapache:developfrom
openMF:FINERACT-2455/working-capital-loan-action-templates
Mar 20, 2026
Merged

FINERACT-2455: Working Capital Loan action templates#5656
adamsaghy merged 1 commit intoapache:developfrom
openMF:FINERACT-2455/working-capital-loan-action-templates

Conversation

@alberto-art3ch
Copy link
Copy Markdown
Contributor

Description

For the UI Working Capital Loan account actions we require template endpoints to get some data and/or options like Payment Type options to apply the desired action from the UI

FINERACT-2455

ie. Approval or Reject the Loan account
Screenshot 2026-03-19 at 3 44 04 PM

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy
Copy link
Copy Markdown
Contributor

* What went wrong:
Execution failed for task ':fineract-working-capital-loan:spotlessJavaCheck'.
> The following files had format violations:
      src/main/java/org/apache/fineract/portfolio/workingcapitalloan/WorkingCapitalLoanConstants.java
          @@ -43,7 +43,7 @@
           ····public·static·final·String·totalPaymentParamName·=·"totalPayment";
           ····public·static·final·String·principalAmountParamName·=·"principalAmount";
           
          -···//·Loan·commands
          +····//·Loan·commands
           ····public·static·final·String·APPROVE_LOAN_COMMAND·=·"approve";
           ····public·static·final·String·DISBURSE_LOAN_COMMAND·=·"disburse";
           }
  Run './gradlew :fineract-working-capital-loan:spotlessApply' to fix these violations.

@adamsaghy adamsaghy force-pushed the FINERACT-2455/working-capital-loan-action-templates branch from c77f4e5 to df3b2d6 Compare March 20, 2026 10:00
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 0675da7 into apache:develop Mar 20, 2026
44 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2455/working-capital-loan-action-templates branch March 20, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants