FINERACT-2454: Migrate LoanWithdrawnByApplicantIntegrationTest from RestAssured to feign client#5668
Open
Dpk376 wants to merge 1 commit intoapache:developfrom
Open
Conversation
Saifulhuq01
reviewed
Mar 22, 2026
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/ClientHelper.java
Outdated
Show resolved
Hide resolved
Saifulhuq01
reviewed
Mar 22, 2026
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/ClientHelper.java
Outdated
Show resolved
Hide resolved
Saifulhuq01
suggested changes
Mar 22, 2026
Contributor
Saifulhuq01
left a comment
Saifulhuq01
left a comment
There was a problem hiding this comment.
please check a point cmds
Dpk376
force-pushed
the
feature/FINERACT-2454-migrate-loan-withdrawn-test
branch
from
d99bb19 to
d79bf72
Compare
Contributor
|
Please run: Before any PR or changes, please always run these two commands and make sure there is green build! |
Dpk376
force-pushed
the
feature/FINERACT-2454-migrate-loan-withdrawn-test
branch
2 times, most recently
from
f511034 to
d0ae703
Compare
Contributor
Author
Yes its been done Adam |
Contributor
Author
Thats been taken care of Saifulhuq01 |
Dpk376
force-pushed
the
feature/FINERACT-2454-migrate-loan-withdrawn-test
branch
2 times, most recently
from
f1dc5b5 to
873ffe5
Compare
Contributor
|
@Dpk376 Please rebase. |
Dpk376
force-pushed
the
feature/FINERACT-2454-migrate-loan-withdrawn-test
branch
2 times, most recently
from
b01b482 to
22f6905
Compare
Contributor
Author
The rebase is done @adamsaghy |
Dpk376
force-pushed
the
feature/FINERACT-2454-migrate-loan-withdrawn-test
branch
from
22f6905 to
d861d76
Compare
…estAssured to fineract-client-feign - Migrates LoanWithdrawnByApplicantIntegrationTest to use fineract-client-feign - Replaces RestAssured based API calls with Feign client - Fixes getObligeeData handling for JSON array response - Applies related test and schema updates # Conflicts: # integration-tests/src/test/java/org/apache/fineract/integrationtests/ClientExternalIdTest.java # integration-tests/src/test/java/org/apache/fineract/integrationtests/common/ClientHelper.java
Dpk376
force-pushed
the
feature/FINERACT-2454-migrate-loan-withdrawn-test
branch
from
d861d76 to
1934cad
Compare
Contributor
Author
|
Hi @adamsaghy This PR is ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes/relates to FINERACT-2454
Migrates
LoanWithdrawnByApplicantIntegrationTestfrom RestAssured to the type-safe feign client, as part of the ongoing test migration effort.Changes
RequestSpecification/ResponseSpecificationboilerplate withextends BaseLoanIntegrationTest@BeforeEachsetup — lifecycle managed byBaseLoanIntegrationTestClientHelper.createClient(requestSpec, responseSpec, ...)→ClientHelper.createClient(PostClientsRequest)LoanProductTestBuilder→createOnePeriod30DaysLongNoInterestPeriodicAccrualProduct()LoanApplicationTestBuilder+CollateralManagementHelper(no feign equivalent) →applyLoan(applyLoanRequest(...))LoanStatusCheckerHashMap-based assertions →verifyLoanStatus(loanId, LoanStatus.*)withdrawLoanApplicationByClient()→withdrawnByApplicantLoan(externalId, PostLoansLoanIdRequest)Result
102 lines → 60 lines. Zero RestAssured imports remaining.
No behavioral changes — the test still verifies that a pending loan application can be withdrawn by the applicant and transitions to
WITHDRAWN_BY_CLIENTstatus.