FINERACT-2515: Fix the TODO comments in the Apache Fineract Code#5672
FINERACT-2515: Fix the TODO comments in the Apache Fineract Code#5672KRYSTALM7 wants to merge 1 commit intoapache:developfrom
Conversation
|
This PR removes three Happy to address any feedback! |
|
@KRYSTALM7 Please configure proper GPG signature for your commits. |
dae1587 to
f7c9d20
Compare
|
Hi @adamsaghy, thank you for the feedback! I have configured GPG signing for my commits and force-pushed both PRs. Happy to address any other feedback! |
|
Please run: Before any PR or changes, please always run these two commands and make sure there is green build! |
f7c9d20 to
510c5d4
Compare
|
Hi @adamsaghy, thanks for the guidance! I have re-run the required checks after my latest changes:
Both commands completed successfully with a green build. Attaching screenshots for verification. |
|
You might wanna extend the scope of this PR by looking for all TODO comments which brings no value... |
|
Thanks for the suggestion! I’ll extend the scope to clean up other TODO comments that don’t add value. |


Description
Removes stale auto-generated TODO stub comments from three classes
in the fineract-loan module as part of the ongoing effort to reduce
technical debt (FINERACT-2515).
Changes
LoanInstallmentCharge.java: Removed
// TODO Auto-generated constructor stubfrom the default no-arg constructor. Theconstructor body is intentionally empty and the comment adds
no value.
LoanTransaction.java: Removed
// TODO Auto-generated method stubfrom theupdateAmount()method. The implementation iscomplete and the comment is misleading.
DuplicateGuarantorException.java: Removed
// TODO Auto-generated constructor stubfrom the parameterizedconstructor. The
super()call is properly implemented.Testing
No functional changes — comments only. Existing tests cover
all modified classes.
Checklist