Skip to content

FINERACT-2515: Fix the TODO comments in the Apache Fineract Code#5672

Open
KRYSTALM7 wants to merge 1 commit intoapache:developfrom
KRYSTALM7:FINERACT-2515-remove-auto-generated-todo-comments
Open

FINERACT-2515: Fix the TODO comments in the Apache Fineract Code#5672
KRYSTALM7 wants to merge 1 commit intoapache:developfrom
KRYSTALM7:FINERACT-2515-remove-auto-generated-todo-comments

Conversation

@KRYSTALM7
Copy link
Copy Markdown
Contributor

Description

Removes stale auto-generated TODO stub comments from three classes
in the fineract-loan module as part of the ongoing effort to reduce
technical debt (FINERACT-2515).

Changes

  • LoanInstallmentCharge.java: Removed // TODO Auto-generated constructor stub from the default no-arg constructor. The
    constructor body is intentionally empty and the comment adds
    no value.

  • LoanTransaction.java: Removed // TODO Auto-generated method stub from the updateAmount() method. The implementation is
    complete and the comment is misleading.

  • DuplicateGuarantorException.java: Removed // TODO Auto-generated constructor stub from the parameterized
    constructor. The super() call is properly implemented.

Testing

No functional changes — comments only. Existing tests cover
all modified classes.

Checklist

  • No functional changes
  • Rebased on latest upstream/develop
  • Follows Fineract coding standards

@KRYSTALM7
Copy link
Copy Markdown
Contributor Author

This PR removes three
stale auto-generated TODO stub comments from the fineract-loan
module as part of FINERACT-2515.

Happy to address any feedback!

@adamsaghy
Copy link
Copy Markdown
Contributor

@KRYSTALM7 Please configure proper GPG signature for your commits.

@KRYSTALM7 KRYSTALM7 force-pushed the FINERACT-2515-remove-auto-generated-todo-comments branch from dae1587 to f7c9d20 Compare March 24, 2026 17:20
@KRYSTALM7
Copy link
Copy Markdown
Contributor Author

Hi @adamsaghy, thank you for the feedback! I have configured GPG signing for my commits and force-pushed both PRs. Happy to address any other feedback!

@adamsaghy
Copy link
Copy Markdown
Contributor

Please run:
./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest
./gradlew --no-daemon build -x test -x cucumber -x doc

Before any PR or changes, please always run these two commands and make sure there is green build!

@KRYSTALM7 KRYSTALM7 force-pushed the FINERACT-2515-remove-auto-generated-todo-comments branch from f7c9d20 to 510c5d4 Compare March 30, 2026 18:03
@KRYSTALM7
Copy link
Copy Markdown
Contributor Author

Hi @adamsaghy, thanks for the guidance!

I have re-run the required checks after my latest changes:

  1. ./gradlew spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest
  2. ./gradlew --no-daemon build -x test -x cucumber -x doc

Both commands completed successfully with a green build.

Attaching screenshots for verification.

Please let me know if any further changes are needed!
Screenshot 2026-03-30 223816
Screenshot 2026-03-30 232756

@adamsaghy
Copy link
Copy Markdown
Contributor

You might wanna extend the scope of this PR by looking for all TODO comments which brings no value...

@KRYSTALM7
Copy link
Copy Markdown
Contributor Author

Thanks for the suggestion! I’ll extend the scope to clean up other TODO comments that don’t add value.
I initially picked this up to get familiar with the codebase and contribution process, and I’m happy to refine it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants