Skip to content

FINERACT-2543: Fix SBOM generation errors and issues#5676

Merged
adamsaghy merged 1 commit intoapache:developfrom
KRYSTALM7:FINERACT-2543-fix-sbom-eclipse-swt-exclusion
Apr 2, 2026
Merged

FINERACT-2543: Fix SBOM generation errors and issues#5676
adamsaghy merged 1 commit intoapache:developfrom
KRYSTALM7:FINERACT-2543-fix-sbom-eclipse-swt-exclusion

Conversation

@KRYSTALM7
Copy link
Copy Markdown
Contributor

JIRA

https://issues.apache.org/jira/browse/FINERACT-2543

Problem

SBOM generation fails with the following error:

'dependencies.dependency.artifactId' for
org.eclipse.platform:org.eclipse.swt.${osgi.platform}:jar
does not match a valid id pattern.

This occurs because org.eclipse.swt uses a platform-specific
artifact ID containing ${osgi.platform} — a Maven property
that the CycloneDX plugin cannot resolve when building the
effective POM.

Fix

Added skipConfigs to exclude eclipse and swt related
configurations from SBOM metadata resolution in the
CyclonedxDirectTask configuration in build.gradle.

Changes

  • build.gradle: Added skipConfigs.set(['.*eclipse.*', '.*swt.*']) to the CyclonedxDirectTask configuration
    to skip unresolvable eclipse/swt dependencies during
    SBOM generation.

Testing

Run the following to verify the fix:
gradlew.bat cyclonedxBom

The task should now complete without the
IllegalStateException for org.eclipse.swt.

@KRYSTALM7
Copy link
Copy Markdown
Contributor Author

Testing Notes

The original org.eclipse.swt POM resolution error is resolved
by this fix. A separate pre-existing Jackson version conflict
(CLEAR_CURRENT_TOKEN_ON_CLOSE) was encountered during testing
which is unrelated to this fix and should be tracked separately.

@adamsaghy
Copy link
Copy Markdown
Contributor

@KRYSTALM7 Please fix the failing checks and make sure you are signing your commits with GPG

@KRYSTALM7 KRYSTALM7 force-pushed the FINERACT-2543-fix-sbom-eclipse-swt-exclusion branch from 614c3a3 to 9944fed Compare March 24, 2026 17:23
@KRYSTALM7
Copy link
Copy Markdown
Contributor Author

Hi @adamsaghy, thank you for the feedback! I have configured GPG signing for my commits. Happy to address any other feedback!

@airajena
Copy link
Copy Markdown
Contributor

Here's one of the failed case-
Failed scenarios:
file:///home/runner/work/fineract/fineract/fineract-e2e-tests-runner/src/test/resources/features/LoanRepayment-Part2.feature:1448 # Verify the due-penalty-interest-principal-fee-in-advance-penalty-interest-principal-fee-strategy payment strategy: UC11 - partial payment, in advance principal, fee, due penalty, principal, fee
50 Scenarios (1 failed, 49 passed)
863 Steps (1 failed, 10 skipped, 852 passed)
8m38.717s
org.opentest4j.AssertionFailedError: [
Number of lines does not match in Transactions tab and expected datatable of resource 136.
Number of transaction tab lines: 7
Number of expected datatable lines: 6
]
expected: 6
but was: 7
at org.apache.fineract.test.stepdef.loan.LoanStepDef.checkLoanTransactionTab(LoanStepDef.java:2420)
at org.apache.fineract.test.stepdef.loan.LoanStepDef.loanTransactionsTabCheck(LoanStepDef.java:2304)
at ✽.Loan Transactions tab has the following data:(file:///home/runner/work/fineract/fineract/fineract-e2e-tests-runner/src/test/resources/features/LoanRepayment-Part2.feature:1538)

Task :fineract-e2e-tests-runner:cucumber FAILED

@KRYSTALM7 KRYSTALM7 force-pushed the FINERACT-2543-fix-sbom-eclipse-swt-exclusion branch from 9944fed to e0b5d59 Compare March 31, 2026 12:14
@KRYSTALM7
Copy link
Copy Markdown
Contributor Author

Hi @adamsaghy,@airajena, I have re-run the required checks after updating the fix:

  1. gradlew.bat spotlessApply spotbugsMain spotbugsTest checkstyleMain checkstyleTest
  2. gradlew.bat --no-daemon build -x test -x cucumber -x doc

Both commands completed successfully with a green build.

Screenshot (965) Screenshot (964)

The fix adds skipConfigs.set(['.*eclipse.*', '.*swt.*']) to the CyclonedxDirectTask configuration in build.gradle, which excludes unresolvable Eclipse/SWT dependencies during SBOM generation and resolves the IllegalStateException for org.eclipse.swt.${osgi.platform}.

Please let me know if any further changes are needed!

@adamsaghy adamsaghy merged commit 4c1444a into apache:develop Apr 2, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants