Skip to content

FINERACT-2421: WorkingCapital loan delinquency start type null#5775

Merged
adamsaghy merged 1 commit intoapache:developfrom
openMF:FINERACT-2421/workingcapital-loan-delinquency-start-type-in-null
Apr 21, 2026
Merged

FINERACT-2421: WorkingCapital loan delinquency start type null#5775
adamsaghy merged 1 commit intoapache:developfrom
openMF:FINERACT-2421/workingcapital-loan-delinquency-start-type-in-null

Conversation

@alberto-art3ch
Copy link
Copy Markdown
Contributor

@alberto-art3ch alberto-art3ch commented Apr 16, 2026

Description

When WorkingCapital loan creation and modification when the DelinquencyStartType is null there was an Internal Server Error

Screenshot 2026-04-15 at 11 06 57 PM

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@budaidev
Copy link
Copy Markdown
Contributor

Can we add extra integration test which cover the initial NPE issue?

@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2421/workingcapital-loan-delinquency-start-type-in-null branch from b322fc7 to c22bf02 Compare April 16, 2026 19:32
@alberto-art3ch alberto-art3ch force-pushed the FINERACT-2421/workingcapital-loan-delinquency-start-type-in-null branch from c22bf02 to 06b844d Compare April 19, 2026 20:48
Copy link
Copy Markdown
Contributor

@Aman-Mittal Aman-Mittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Ok, Please resolve my comment answering. PR seems to be related to handle null values. Maybe we can add relevent tests later. If there any null issues for coverage

@adamsaghy adamsaghy merged commit d74cdc5 into apache:develop Apr 21, 2026
57 of 58 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2421/workingcapital-loan-delinquency-start-type-in-null branch April 21, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants