FINERACT-2455: WC - Transaction Type - CBR

[mariiaKraievska]

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[Aman-Mittal]

Hi @adamsaghy,

I attempted to review the ticket at https://issues.apache.org/jira/browse/FINERACT-2455
, but I couldn’t find any clearly documented use case or requirements associated with it. I also noticed that several PRs have already been merged under this ticket.

My main concern is that most of the documentation appears to reside within the codebase (e.g., adoc files), rather than being captured in the ticket or on the dev mailing list. Could you please confirm if there are additional discussions or references that should be reviewed?

Since you are leading this feature, it would be very helpful if the implementation scope and requirements were clearly outlined in the ticket to ensure better visibility and alignment for contributors. It would also greatly assist newcomers when reviewing the code and trying to understand or ask questions about the intended use cases.

Thanks.

[adamsaghy]

@mariiaKraievska Please rebase

[adamsaghy]

  required: EventMessage<R>
  found:    EventMessage<CAP#1>
  where R,T are type-variables:
    R extends Object declared in method <R,T>findByType(T)
    T extends Event<R> declared in method <R,T>findByType(T)
  where CAP#1 is a fresh type-variable:
    CAP#1 extends Object from capture of ?
/home/runner/work/fineract/fineract/fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/WorkingCapitalLoanAccountStepDef.java:1718: error: cannot find symbol
                () -> fineractClient.workingCapitalLoanTransactions().retrieveWorkingCapitalLoanTemplate1(loanId, command));
                                                                     ^

[adamsaghy]

Hi @adamsaghy,

I attempted to review the ticket at https://issues.apache.org/jira/browse/FINERACT-2455 , but I couldn’t find any clearly documented use case or requirements associated with it. I also noticed that several PRs have already been merged under this ticket.

My main concern is that most of the documentation appears to reside within the codebase (e.g., adoc files), rather than being captured in the ticket or on the dev mailing list. Could you please confirm if there are additional discussions or references that should be reviewed?

Since you are leading this feature, it would be very helpful if the implementation scope and requirements were clearly outlined in the ticket to ensure better visibility and alignment for contributors. It would also greatly assist newcomers when reviewing the code and trying to understand or ask questions about the intended use cases.

Thanks.

Hi @Aman-Mittal

You are right, we should have some documentation under the Apache Fineract Jira tickets as well. Let me review the umbrella ticket and add the missing informations. In the meantime, the fineract-doc and the PR implementation reflects the behaviour (in this case, there is no difference it behaviour, just a different loan product)