Skip to content

FINERACT-2421: Optimize test cases and execution#5815

Merged
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2421/optimize-test-cases-and-execution
May 8, 2026
Merged

FINERACT-2421: Optimize test cases and execution#5815
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2421/optimize-test-cases-and-execution

Conversation

@adamsaghy
Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy adamsaghy force-pushed the FINERACT-2421/optimize-test-cases-and-execution branch 9 times, most recently from 497c577 to 3096abe Compare May 1, 2026 15:59
@meonkeys
Copy link
Copy Markdown
Contributor

meonkeys commented May 5, 2026

@adamsaghy will you please summarize this PR? I'd like a bit more context beyond the PR title and short of the diff itself. I did skim the diff but it's not obvious to me what all the changes are for. I see changes in sleeps, capitalization, dates... is there some guide to what this PR does and why? Discussion on the list or in chat? Research leading to its creation? Before and after test case timing/behavior?

@adamsaghy
Copy link
Copy Markdown
Contributor Author

@adamsaghy will you please summarize this PR? I'd like a bit more context beyond the PR title and short of the diff itself. I did skim the diff but it's not obvious to me what all the changes are for. I see changes in sleeps, capitalization, dates... is there some guide to what this PR does and why? Discussion on the list or in chat? Research leading to its creation? Before and after test case timing/behavior?

You are right! It's quite cryptic in this format :)

The idea is:

  • to initialized test data parallel with multiple threads
  • Remove hardcoded test data ids (hard coded PK keys)
  • Fetch data from cache
  • Remove unnecessary jumps in time which is causing long running test scenarios
  • Run clean up processes parallel (close loan, close savings account)
    etc.

@adamsaghy adamsaghy force-pushed the FINERACT-2421/optimize-test-cases-and-execution branch from 3096abe to ad83cfb Compare May 7, 2026 22:59
@adamsaghy adamsaghy merged commit 800f6b0 into apache:develop May 8, 2026
106 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2421/optimize-test-cases-and-execution branch May 8, 2026 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants