Skip to content

FINERACT-1222: Add Swagger tags for Notifications#5832

Merged
adamsaghy merged 1 commit into
apache:developfrom
elicsmit:fix-swagger-notifications
May 19, 2026
Merged

FINERACT-1222: Add Swagger tags for Notifications#5832
adamsaghy merged 1 commit into
apache:developfrom
elicsmit:fix-swagger-notifications

Conversation

@elicsmit
Copy link
Copy Markdown
Contributor

@elicsmit elicsmit commented May 8, 2026

Description

This PR adds missing Swagger API documentation tags and operation summaries for the Notification functional area. This is part of the task FINERACT-1222. To ensure a better review process, I have decomposed the changes into smaller parts, and this Pull Request specifically focuses on the notification package.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

@elicsmit elicsmit force-pushed the fix-swagger-notifications branch 3 times, most recently from 418e8b5 to b4e6f96 Compare May 8, 2026 20:20
@elicsmit elicsmit force-pushed the fix-swagger-notifications branch from b4e6f96 to b1189e4 Compare May 8, 2026 20:22
Copy link
Copy Markdown
Member

@Aman-Mittal Aman-Mittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems Ok to merge

@elicsmit
Copy link
Copy Markdown
Contributor Author

@adamsaghy Hi! This PR is fully approved by the reviewers. Could you please merge this when you have a moment? Thank you!

@adamsaghy adamsaghy merged commit ec24f30 into apache:develop May 19, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants