FINERACT-2421: Add equals() and hashCode() to LoanTransaction

[Harshdhall01]

Description

LoanTransaction was missing equals() and hashCode() implementations,
flagged by a long-standing TODO comment in the code:

// TODO missing hashCode(), equals(Object obj), but probably OK as long as
// this is never stored in a Collection.

The parent class AbstractPersistableCustom intentionally omits these methods
(documented in its own Javadoc). Added id-based implementations consistent with
the pattern already used in LoanDisbursementDetails, ensuring correct behavior
if LoanTransaction is ever used in hash-based collections.

Changes

• Removed stale TODO comment
• Added equals() based on entity id with null-safety for unsaved entities
• Added hashCode() based on entity id
• Added missing java.util.Objects import

---

I am exploring this codebase as part of my DMP 2026 (C4GT) application for the
"Dynamic Pricing of Micro-loans Using Reinforcement Learning" project under
openMF/Mifos. The loan module is directly relevant as it contains the core
transaction logic that my RL environment will model for dynamic pricing decisions.

Checklist

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build
• Create/update unit or integration tests for verifying the changes made
• Follow our coding conventions
• Add required Swagger annotation and update API documentation
• This PR must not be a "code dump"

[adamsaghy]

@Harshdhall01 Please use FINERACT-2421 for this.

[Harshdhall01]

Thank you @adamsaghy! Sir Updated the commit and PR title to FINERACT-2421.

[Harshdhall01]

The build failure in fineract-progressive-loan is a pre-existing
ReferenceEquality issue in AdvancedPaymentScheduleTransactionProcessor.java
(lines 1267, 1358) that uses == instead of .equals() for LoanTransaction
comparison. This is unrelated to my change — the errorprone check flags
reference equality regardless of whether equals() is implemented.

[adamsaghy]

The build failure in fineract-progressive-loan is a pre-existing ReferenceEquality issue in AdvancedPaymentScheduleTransactionProcessor.java (lines 1267, 1358) that uses == instead of .equals() for LoanTransaction comparison. This is unrelated to my change — the errorprone check flags reference equality regardless of whether equals() is implemented.

It fails because now there is a value equality method available and it tries to enforce it now :)

You should fix these issues by modifying to use from now on the equals method

[Harshdhall01]

Thank you for the explanation @adamsaghy! Sir Fixed both lines in AdvancedPaymentScheduleTransactionProcessor.java to use Objects.equals() instead of ==. Force pushed the updated commit.

[adamsaghy]

@Harshdhall01 Please review and resolve the build issues

[Harshdhall01]

@adamsaghy Sir Fixed the spotless formatting violations — removed extra blank lines in LoanTransaction.java. Force pushed the updated commit.

[Harshdhall01]

@adamsaghy Sir All build issues resolved! spotless, checkstyle, and all integration tests are passing. The only remaining failure is api-compatibility-check which appears to be a pre-existing issue on develop unrelated to this change.
Ready for review!

[adamsaghy]

LGTM