Skip to content

FINERACT-2455: WC - Transaction Type - Discount adjustment#5861

Merged
adamsaghy merged 2 commits into
apache:developfrom
openMF:FINERACT-2455/working-capital-transaction-type-discount-adjustment
Jun 1, 2026
Merged

FINERACT-2455: WC - Transaction Type - Discount adjustment#5861
adamsaghy merged 2 commits into
apache:developfrom
openMF:FINERACT-2455/working-capital-transaction-type-discount-adjustment

Conversation

@mariiaKraievska
Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@mariiaKraievska mariiaKraievska changed the title FINERACT-2421: WC - Transaction Type - Discount adjustment FINERACT-2455: WC - Transaction Type - Discount adjustment May 19, 2026
@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-transaction-type-discount-adjustment branch 10 times, most recently from 4a4b992 to 28451f1 Compare May 26, 2026 11:59
@adamsaghy adamsaghy marked this pull request as ready for review May 26, 2026 12:53
@adamsaghy adamsaghy closed this May 26, 2026
@adamsaghy adamsaghy reopened this May 26, 2026
@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-transaction-type-discount-adjustment branch 3 times, most recently from b021fd2 to 2690bca Compare May 27, 2026 15:00
Copy link
Copy Markdown
Contributor

@galovics galovics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread fineract-doc/src/docs/en/chapters/features/working-capital-discount-fee-txn.adoc Outdated
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly review my concerns.

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-transaction-type-discount-adjustment branch 2 times, most recently from fde536f to a7407d7 Compare June 1, 2026 11:00
@adamsaghy
Copy link
Copy Markdown
Contributor

> License violations were found: /home/runner/work/fineract/fineract/fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/data/RepaymentAmortizationData.java}
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-transaction-type-discount-adjustment branch from a7407d7 to 9b9c7c7 Compare June 1, 2026 12:40
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-transaction-type-discount-adjustment branch from 9b9c7c7 to 5691745 Compare June 1, 2026 15:20
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 5251ce1 into apache:develop Jun 1, 2026
88 of 89 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2455/working-capital-transaction-type-discount-adjustment branch June 1, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants