Skip to content

FINERACT-2611: Allow MakerCheckerRequest does not accept makerDateTim…#5864

Merged
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2611/makercheckerrequest-does-not-accept-datetime-properly
May 28, 2026
Merged

FINERACT-2611: Allow MakerCheckerRequest does not accept makerDateTim…#5864
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2611/makercheckerrequest-does-not-accept-datetime-properly

Conversation

@Vectorquantiy
Copy link
Copy Markdown
Contributor

@Vectorquantiy Vectorquantiy commented May 20, 2026

…eFrom and makerDateTimeTo properly

Description

@QueryParam does not automatically convert String query parameters into java.time.ZonedDateTime.
Therefor makerDateTimeFrom and makerDateTimeTo is always resolving to null in MakerCheckerRequest.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy
Copy link
Copy Markdown
Contributor

@Vectorquantiy Please fix the failing CI checks and ensure you have properly configured GPG commit signature in place.

…eFrom and makerDateTimeTo properly

Address PR review comments

Fixed checkstyle
@Vectorquantiy Vectorquantiy force-pushed the FINERACT-2611/makercheckerrequest-does-not-accept-datetime-properly branch from 0c589b7 to fe70b79 Compare May 27, 2026 06:57
@marta-jankovics marta-jankovics requested a review from adamsaghy May 27, 2026 11:04
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 414aec0 into apache:develop May 28, 2026
89 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2611/makercheckerrequest-does-not-accept-datetime-properly branch May 28, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants