FINERACT-2455: Auto-generate externalId for WC discount fee transactions

[oleksii-novikov-onix]

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[galovics]

One thing I'm not sure about in the validator change.

WorkingCapitalLoanDataValidator.java:

-        if (expectedDisbursementDate != null && approvedOnDate != null && DateUtils.isBefore(expectedDisbursementDate, approvedOnDate)) {
+        if (expectedDisbursementDate != null && DateUtils.isBefore(expectedDisbursementDate, approvedOnDate)) {

Why remove the approvedOnDate != null guard? In validateApproval the error accumulation pattern means approvedOnDate can still be null past the notNull() check (the error is collected, not thrown). If the caller omits approvedOnDate, DateUtils.isBefore(date, null) will NPE rather than producing a proper validation error.

[oleksii-novikov-onix]

One thing I'm not sure about in the validator change.

WorkingCapitalLoanDataValidator.java:

-        if (expectedDisbursementDate != null && approvedOnDate != null && DateUtils.isBefore(expectedDisbursementDate, approvedOnDate)) {
+        if (expectedDisbursementDate != null && DateUtils.isBefore(expectedDisbursementDate, approvedOnDate)) {

Why remove the approvedOnDate != null guard? In validateApproval the error accumulation pattern means approvedOnDate can still be null past the notNull() check (the error is collected, not thrown). If the caller omits approvedOnDate, DateUtils.isBefore(date, null) will NPE rather than producing a proper validation error.

Hello @galovics , DateUtils.isBefore is null-safe on both arguments, when the second argument is null, it returns false.

[adamsaghy]

LGTM

Asked and answered.