-
Notifications
You must be signed in to change notification settings - Fork 2.5k
FINERACT-2616: OIDC Federation support for IdP #5883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alberto-art3ch
wants to merge
1
commit into
apache:develop
Choose a base branch
from
openMF:FINERACT-2616/oidc-federation-support-for-idp
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
...t-core/src/main/java/org/apache/fineract/infrastructure/core/domain/TenantOidcConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.fineract.infrastructure.core.domain; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.EqualsAndHashCode; | ||
| import lombok.Getter; | ||
| import lombok.Setter; | ||
| import org.apache.fineract.infrastructure.security.domain.OidcFederationType; | ||
|
|
||
| /** | ||
| * Holds the per-tenant OIDC/IdP configuration stored in the master database (m_tenant_oidc_config). One record per | ||
| * tenant; the issuerUri is the resolution key matched against the JWT 'iss' claim. | ||
| */ | ||
| @Builder | ||
| @Getter | ||
| @Setter | ||
| @EqualsAndHashCode(of = "issuerUri") | ||
| public class TenantOidcConfig { | ||
|
|
||
| private Long id; | ||
| private String tenantId; | ||
| private OidcFederationType providerType; | ||
| private String issuerUri; | ||
| private String clientId; | ||
| /** Stored AES-256-GCM encrypted; never exposed in API responses. */ | ||
| private String clientSecret; | ||
| /** Optional: if null, derived from issuerUri via OIDC discovery. */ | ||
| private String jwksUri; | ||
| private String usernameClaim; | ||
| private String scopes; | ||
| private String postLogoutRedirectUri; | ||
| private boolean enabled; | ||
| } |
34 changes: 34 additions & 0 deletions
34
.../src/main/java/org/apache/fineract/infrastructure/security/domain/OidcFederationType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.fineract.infrastructure.security.domain; | ||
|
|
||
| import lombok.Getter; | ||
| import lombok.RequiredArgsConstructor; | ||
| import org.apache.fineract.infrastructure.core.api.ApiFacingEnum; | ||
|
|
||
| @Getter | ||
| @RequiredArgsConstructor | ||
| public enum OidcFederationType implements ApiFacingEnum<OidcFederationType> { | ||
|
|
||
| GENERIC("generic", "Generic (default)"), AUTH0("auth0", "Auth0"), AZURE("azure_ad", "Azure AD"), GOOGLE("google", | ||
| "Google"), KEYCLOAK("keycloak", "Keycloak"), OKTA("okta", "Okta"),; | ||
|
|
||
| private final String code; | ||
| private final String humanReadableName; | ||
| } |
62 changes: 62 additions & 0 deletions
62
.../test/java/org/apache/fineract/infrastructure/core/config/FineractPropertiesOidcTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.apache.fineract.infrastructure.core.config; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import org.apache.fineract.infrastructure.core.config.FineractProperties.FineractSecurityProperties.FineractSecurityOidcFederationProperties; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class FineractPropertiesOidcTest { | ||
|
|
||
| @Test | ||
| void defaultEnabledIsFalse() { | ||
| assertThat(new FineractSecurityOidcFederationProperties().isEnabled()).isFalse(); | ||
| } | ||
|
|
||
| @Test | ||
| void defaultUsernameClaimIsPreferredUsername() { | ||
| assertThat(new FineractSecurityOidcFederationProperties().getUsernameClaim()).isEqualTo("preferred_username"); | ||
| } | ||
|
|
||
| @Test | ||
| void defaultTenantClaimName() { | ||
| assertThat(new FineractSecurityOidcFederationProperties().getTenantClaimName()).isEqualTo("fineract_tenant"); | ||
| } | ||
|
|
||
| @Test | ||
| void defaultAutoCreateUserIsFalse() { | ||
| assertThat(new FineractSecurityOidcFederationProperties().isAutoCreateUser()).isFalse(); | ||
| } | ||
|
|
||
| @Test | ||
| void defaultProviderIsGeneric() { | ||
| assertThat(new FineractSecurityOidcFederationProperties().getProvider().getCode()).isEqualTo("generic"); | ||
| } | ||
|
|
||
| @Test | ||
| void defaultDefaultRolesIsEmpty() { | ||
| assertThat(new FineractSecurityOidcFederationProperties().getDefaultRoles()).isEmpty(); | ||
| } | ||
|
|
||
| @Test | ||
| void defaultPostLogoutRedirectUriIsNull() { | ||
| assertThat(new FineractSecurityOidcFederationProperties().getPostLogoutRedirectUri()).isNull(); | ||
| } | ||
| } |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| .Project Overview | ||
| * xref:index.adoc[Introduction] | ||
| * xref:faq.adoc[FAQs] | ||
|
|
||
| .Security & Configuration | ||
| * xref:oidc-federation.adoc[OIDC Federation] | ||
| ** xref:oidc-federation-google.adoc[Google Identity Provider] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks messy to me...
Why should we have any of the below fields as configuration: