Skip to content

FINERACT-2165: Migrate TaxComponentHelper and TaxGroupHelper to fineract-client-feign#5885

Merged
adamsaghy merged 1 commit into
apache:developfrom
elnafateh:FINERACT-2165/migrate-tax-helpers
May 25, 2026
Merged

FINERACT-2165: Migrate TaxComponentHelper and TaxGroupHelper to fineract-client-feign#5885
adamsaghy merged 1 commit into
apache:developfrom
elnafateh:FINERACT-2165/migrate-tax-helpers

Conversation

@elnafateh
Copy link
Copy Markdown
Contributor

Description

Part of FINERACT-2165 — system-wide migration of integration tests from RestAssured to fineract-client-feign.

This PR completes the migration of TaxComponentHelper and TaxGroupHelper, and updates the 3 test files that called their now-removed deprecated methods.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@elnafateh
Copy link
Copy Markdown
Contributor Author

kindly rerun failed test, it's flaky

Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 6d3cecf into apache:develop May 25, 2026
105 of 106 checks passed
@elnafateh elnafateh deleted the FINERACT-2165/migrate-tax-helpers branch May 25, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants