Skip to content

FINERACT-2455: WC - Transaction Type - Discount amortization adjustment#5889

Merged
adamsaghy merged 2 commits into
apache:developfrom
openMF:FINERACT-2455/working-capital-transaction-type-discount-amortization-adjustment
Jun 5, 2026
Merged

FINERACT-2455: WC - Transaction Type - Discount amortization adjustment#5889
adamsaghy merged 2 commits into
apache:developfrom
openMF:FINERACT-2455/working-capital-transaction-type-discount-amortization-adjustment

Conversation

@mariiaKraievska
Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy adamsaghy marked this pull request as ready for review May 26, 2026 12:53
@adamsaghy adamsaghy closed this May 26, 2026
@adamsaghy adamsaghy reopened this May 26, 2026
@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-transaction-type-discount-amortization-adjustment branch from e166ce1 to c50c69f Compare May 27, 2026 07:05
Copy link
Copy Markdown
Contributor

@galovics galovics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariiaKraievska mariiaKraievska marked this pull request as draft May 28, 2026 09:13
@adamsaghy adamsaghy marked this pull request as ready for review June 1, 2026 12:59
@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-transaction-type-discount-amortization-adjustment branch 3 times, most recently from 9d2d625 to a6f20d0 Compare June 2, 2026 07:31
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariiaKraievska
Copy link
Copy Markdown
Contributor Author

Just a heads-up: please don't merge this PR yet, @MarianaDmytrivBinariks wants to add some additional tests

Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As requested, I put a hold on this PR.

@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-transaction-type-discount-amortization-adjustment branch from edaabde to db14b94 Compare June 3, 2026 13:13
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2455/working-capital-transaction-type-discount-amortization-adjustment branch 2 times, most recently from 2f5f55c to 069d9af Compare June 3, 2026 17:40
@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-transaction-type-discount-amortization-adjustment branch 2 times, most recently from 8b64665 to 0c6c6e2 Compare June 4, 2026 13:42
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2455/working-capital-transaction-type-discount-amortization-adjustment branch from 0c6c6e2 to 3f002de Compare June 4, 2026 14:07
@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-transaction-type-discount-amortization-adjustment branch from 3f002de to b4dc679 Compare June 4, 2026 14:40
@mariiaKraievska mariiaKraievska force-pushed the FINERACT-2455/working-capital-transaction-type-discount-amortization-adjustment branch from b4dc679 to 4fe53fd Compare June 5, 2026 06:58
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsaghy adamsaghy merged commit 76dc190 into apache:develop Jun 5, 2026
89 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2455/working-capital-transaction-type-discount-amortization-adjustment branch June 5, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants