Skip to content

FINERACT-2165: Migrate AccountRuleHelper and PeriodicAccrualAccountingHelper to fineract-client-feign#5900

Open
elnafateh wants to merge 1 commit into
apache:developfrom
elnafateh:FINERACT-2165/migrate-accountrule-periodicaccrual
Open

FINERACT-2165: Migrate AccountRuleHelper and PeriodicAccrualAccountingHelper to fineract-client-feign#5900
elnafateh wants to merge 1 commit into
apache:developfrom
elnafateh:FINERACT-2165/migrate-accountrule-periodicaccrual

Conversation

@elnafateh
Copy link
Copy Markdown
Contributor

Description

Part of FINERACT-2165 system-wide migration of integration tests from RestAssured to fineract-client-feign.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@elnafateh elnafateh force-pushed the FINERACT-2165/migrate-accountrule-periodicaccrual branch from 738ccac to d065c41 Compare May 28, 2026 10:53
@elnafateh
Copy link
Copy Markdown
Contributor Author

elnafateh commented May 30, 2026

Kindly rerun failed check, it's flaky

Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly review my concerns.

@elnafateh elnafateh force-pushed the FINERACT-2165/migrate-accountrule-periodicaccrual branch from d065c41 to a03b5d6 Compare June 3, 2026 15:31
@elnafateh
Copy link
Copy Markdown
Contributor Author

elnafateh commented Jun 3, 2026

Kindly review my concerns.

@adamsaghy they're now resolved

@elnafateh elnafateh requested a review from adamsaghy June 3, 2026 15:36
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elnafateh
Copy link
Copy Markdown
Contributor Author

kindly rerun failed check, it's flaky error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants