Skip to content

FINERACT-2421: Enhance Github actions workflow (docker log, interpolations, etc.)#5908

Merged
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2421/enhance-github-actions-workflow
May 31, 2026
Merged

FINERACT-2421: Enhance Github actions workflow (docker log, interpolations, etc.)#5908
adamsaghy merged 1 commit into
apache:developfrom
openMF:FINERACT-2421/enhance-github-actions-workflow

Conversation

@adamsaghy
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy commented May 29, 2026

Description

  • Added Docker log artifacts and cleanup to build-docker.yml and smoke-messaging.yml.
  • Fixed build-docker.yml so check_worker_health is actually used for MariaDB worker health/info checks.
  • Hardened unsafe PR event interpolation in pr-title-check.yml and verify-api-backward-compatibility.yml.
  • Reviewed permissions: the workflows are now least-privilege for their behavior. Most only need contents: read; PR title check uses pull-requests: read; stale keeps write permissions because it closes/issues PRs.
  • Remove PR comment logic (it was not working due to safety concerns)
  • Remove mifos-fineract-client-publush.yml -> Moving to Mifos repository (where it belongs)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Copy link
Copy Markdown
Member

@Aman-Mittal Aman-Mittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe to merge Refactoring and security hardening is done in This PR

@adamsaghy adamsaghy force-pushed the FINERACT-2421/enhance-github-actions-workflow branch from 19b098c to 035f88b Compare May 31, 2026 12:05
@adamsaghy adamsaghy merged commit a598284 into apache:develop May 31, 2026
89 checks passed
@adamsaghy adamsaghy deleted the FINERACT-2421/enhance-github-actions-workflow branch May 31, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants