FINERACT-2421: Rework Github Actions workflow#5935
Conversation
a0889fc to
ae60bcc
Compare
ae60bcc to
23258ad
Compare
|
Please add a description |
|
I like being able to just grab the entire workspace and tinker with it. That really helped when I was debugging failing cucumber tests... I was able to try the same I get that it is a good chunk of storage to deal with, though. What's the benefit/effect of moving logic from |
@meonkeys Its the same now, and we probably stick with building workspace and reuse it. This change was merely refactoring, so it can be reused (which is not at the moment...) |
Aman-Mittal
left a comment
There was a problem hiding this comment.
Ready for merge, Tests are running OK , NO security issues i have found, and re run is working ok on single shard.
Description
This PR is trying to improve on multiple ways of our CI execution:
Having a common action to setup and build Fineract -> action.yml
Uploading and archiving artifacts (logs) only if workflow job fails. In case of success, these are not relevant anymore -> No need to upload and store them (except workspace...)
Retention days to be reduced to 5 day: More than enough to evaluate logs, no need to further collect and store them
Compression level to be increased, even the used artifact storages should be minimal -> Consideration for users who are running Fineract CI on private repo or their own runner.
Timeout: Increased timeout to ensure, even if the job is queued for a longer time, still fit into the timeframe
Limiting branches to be used to execute full CI -> By default only develop (later main) and releases and tags to be considered
Adding concurrency group and cancel prior execution in case a CI execution is triggered on a newer version of the code changes / PR
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.